Feature/evsemanager persistent transactions #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
force-pushed
the
feature/evsemanager_persistent_transactions
branch
from
74a86fa to
74a7277
Compare
4 tasks
Pietfried
force-pushed
the
feature/evsemanager_persistent_transactions
branch
2 times, most recently
from
19d5641 to
acc7a34
Compare
Pietfried
reviewed
Jul 25, 2024
Pietfried
force-pushed
the
feature/evsemanager_persistent_transactions
branch
from
1f171d7 to
4079b07
Compare
Pietfried
requested review from
hikinggrass,
maaikez and
SebaLukas
as code owners
corneliusclaussen
force-pushed
the
feature/evsemanager_persistent_transactions
branch
from
f4e0b3f to
ff2d0fe
Compare
Pietfried
force-pushed
the
feature/evsemanager_persistent_transactions
branch
from
ff2d0fe to
f6a337f
Compare
hikinggrass
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
TODO: update dependencies
| @@ -0,0 +1,44 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| // Copyright 2023 Pionix GmbH and Contributors to EVerest | |||
There was a problem hiding this comment.
2024 or leave the date out entirely
| @@ -0,0 +1,33 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| // Copyright 2020 - 2021 Pionix GmbH and Contributors to EVerest | |||
There was a problem hiding this comment.
2024 or leave out entirely
Implementation of evse_board_support was simplified a bit. The sync command to get hw capablities on startup is no longer needed as the async publish of capablities is enough. Each BSP implementation module is required to publish its capablities at least once in the ready function. It may publish it later on to update the values e.g. for thermal derating. 1ph/3ph switching support during charging with a hyteresis if the 1ph/3ph power ranges overlap (e.g. on 22kW). Hysteresis only really works if EV and EVSE have the same max current rating, e.g. both 16A See doc.rst for details. Signed-off-by: Cornelius Claussen <[email protected]> Signed-off-by: pietfried <[email protected]>
If EvseManager has a connection to a PersistentStore/kvs module, it now stores the transaction UUID persistently. It checks on startup if a transaction is still ongoing and tries to close it in the power meter to fetch the OCMF data. Then it emits a TransactionFinished event (with OCMF included if the powermeter transaction stop was successful, otherwise the event is sent without OCMF). After that it clears any other transaction that still may be ongoing in the powermeter by calling stop_transaction with an empty string as session id. LEM driver was adapted to support the cleanup with empty UUIDs on start up. Signed-off-by: Cornelius Claussen <[email protected]> Signed-off-by: florinmihut <[email protected]> Signed-off-by: pietfried <[email protected]>
…indicate that a previous session has been resumed at startup * Added subscription to this event to OCPP module so that OCPP is aware that the EvseManager is aware of previous transactions. This allows OCPP to not terminate such transactions individually every time Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: florinmihut <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: florinmihut <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
Pietfried
force-pushed
the
feature/evsemanager_persistent_transactions
branch
from
f6a337f to
3d1328e
Compare
Signed-off-by: pietfried <[email protected]>
Pietfried
reviewed
Jul 31, 2024
Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
SessionResumedto allow the evse_manager to indicate that a previous session has been resumed at startupIssue ticket number and link
Companion PR in libocpp: EVerest/libocpp#704
Checklist before requesting a review